[Export] Convert testGender Export to new test format. #14914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a tangental cleanup & fix whereby the test covers a label longer than 16 char & the code for prefix_id & suffix_id is consolidated by handling the special casing in the metadata declaration rather than in multiple places.
|
(Standard links)
|
eileenmcnaughton
changed the title
|
@colemanw another |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is part of switching the tests to a new cleaner method
It includes a tangental cleanup & fix whereby I add test cover for a gender label longer than 16 char & consolidate the handling of gender & the other special case fields (prefix_id, suffix_id & communication_style_id) by handling the special casing in the metadata declaration
on the query object
Before
Less std, gender labels longer than 16 char cause export fails
After
More std, long gender labels are supported
Technical Details
Early on in the switch to metadata handling for fields like gender_id, prefix_id the query object was updated to overwrite those fields with the label when processing out. More recently we adopted a pattern of outputting the original field AND a pseudofield with the field name being the option group name. This makes the handling of the first set clearer & means they are output correctly in export as a byproduct.
Comments