[REF] remove never-set, mispelt parameter #14907
Conversation
|
(Standard links)
|
| @@ -888,7 +888,7 @@ public static function formRule($fields, $files, $form) { | |||
| $isZeroAmount = TRUE; | |||
| } | |||
|
|
|||
| if ($isZeroAmount && !($form->_forcePayement && !empty($fields['additional_participants']))) { | |||
| if ($isZeroAmount) { | |||
There was a problem hiding this comment.
hang on have I got this right - $form->_forcePayement was ALWAYS false so it was never the case that the second condition was true & hence it was meaningless
There was a problem hiding this comment.
I think that is right unless it works becasue !FALSE but urg that is annoying as hell might be worth just testing with a small PHP script of something like
if (!(FALSE && !empty(['hi'])) {
print_r('See hi');
}
else {
print_r('So it wasn't validating');
}
There was a problem hiding this comment.
doing testing found that even if the 2nd part of that inner IF was TRUE the whole section was returning TRUE because forcePayment was false so Not FALSE is TRUE so makes sense to clear it all out.
There was a problem hiding this comment.
it was a mind mess though!
|
Changes look good and fine to me and i am confident we have reasonable tests in this area merging |
Overview
On digging into an issue around multiple payments I found the parameter $form->_forcePayement if never set to TRUE (the place where it was obviously expected to be possibly set was commented out) so it should go
Before
Parameter present
After
poof
Technical Details
Note I removed an 'if' that relies on it being TRUE since it never is
Comments
I am digging into eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor#127 & I know that many years ago I wrote the code to move the payment block off the first page in this flow but abandoned it unreviewed (mostly because it was before LeXIM & it the processes were poorer back then).
I suspect this might be part of that abandoned attempt