Use singleton to get session instead of relying on ->_session being set elsewhere

[mattwire]

Overview

CRM_Profile_Form relies on $this->_session being set but we should just call CRM_Core_Session::singleton() and not worry about it.

Before

$this->_session must be set by calling class (eg. in GDPR extension). If it's not set we get a fatal error.

After

Use the standard CRM_Core_Session::singleton() method to get the session object - so we won't get fatal errors if the calling function hasn't set $this->_session.

Technical Details

Just switching to a more standard, more reliable method for this class.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Makes sense to me. Caching an object that's already cached in a singleton isn't doing any good.