[REF] Cleanup up handling of dates for Recurring & Contribution date fields in query class #14825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query object This gets us to the point where all date fields are handled the same way, which is now tested. Now that recurring contribution fields have unique keys we can handle them as metadata
|
(Standard links)
|
eileenmcnaughton
changed the title
|
test this please |
|
Changes make sense to me and expands test coverage merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleanup contribution & recurring contribution date field handling in query object
This gets us to the point where all contribution date fields are handled the same way, which is now tested. Now that recurring contribution fields have unique keys we can handle them as metadata
Before
Less consistent code
After
More consistent code
Technical Details
@seamuslee001 if you merge this you can remove all the query object stuff from #14737 because the recurring date fields will have generic handling
Comments