Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] [Export] move mergeSameAddress to processor class #14809

Merged
merged 1 commit into from
Jul 12, 2019
Merged

[REF] [Export] move mergeSameAddress to processor class #14809

merged 1 commit into from
Jul 12, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 12, 2019 •
edited
Loading

Overview

Minor code move

Before

mergeSameAddress on BAO_Export

After

mergeSameAddress moved to ExportProcessor

Technical Details

Part of export cleanup - just moving function between classes

Comments

Test cover is good

@civibot
Copy link

civibot bot commented Jul 12, 2019

(Standard links)

@civibot civibot bot added the master label Jul 12, 2019
@colemanw
Copy link
Member

Code looks good.

@eileenmcnaughton eileenmcnaughton merged commit 5d4afc8 into civicrm:master Jul 12, 2019
@eileenmcnaughton eileenmcnaughton deleted the ex_merge branch July 12, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw