[NFC] [REF] [TEST] [EXPORT] Update various export tests to test csv output with new functions #14780
Conversation
|
(Standard links)
|
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
export_test2
branch
from
14d29bd to
672fb2d
Compare
|
I think this is unrelated |
|
@colemanw I think this is mergeable |
|
retest this please |
Note we are implictly checking headers so no need to do so separately
The move from testing sqlColumns to csv output is deliberate. While refactoring, cleaning up the sqlColumns stuff having test on it was VERY helpful. But, at the end of the day the csv IS the output and testing that allows us to improve the mechanism to develop that output
eileenmcnaughton
force-pushed
the
export_test2
branch
from
672fb2d to
9d7c879
Compare
|
@colemanw this . is passing now |
|
@seamuslee001 wanna merge this - should be a no brainer as it's tests only & it passes |
| } | ||
| } | ||
|
|
||
| $this->assertEquals([ | ||
| 'billing_im_provider' => 'billing_im_provider text', |
There was a problem hiding this comment.
@eileenmcnaughton i just wonder are we loosing anything with this?
There was a problem hiding this comment.
well we are losing the workings of the function - ie what sort of fields it writes to the temp table. That felt very important when cleaning up that part of the function but I aspire to change the way in which it writes to the temp tables in future (ie either not write to them when not required or just write the id & transform on output) so I want to switch to testing the outcomes rather than the internals
|
This PR title wins the Most Acronyms in Square Brackets award 🏆 |
|
My life is fulfilled |
Overview
Updates some unit tests on export functionality to use preferred methodology
Before
Testing created temp table
After
Testing csv output
Technical Details
Because he is wiser than all of us @totten pointed out that we could throw an exception in the civiExit process for unit tests. This, combined with shipping phpleague csv package gave us a way to test the actual output. This upgrades some tests to do that. Testing thee csv output rather than the temptable details is preferred because the temp table is 'the workings' and in many cases would be better not created at all. Testing the columns created was REALLY useful when we were refactoring that but I don't believe removing that chunk now loses us any coverage
Comments