Extract field wrangling to determineReturnProperties

[eileenmcnaughton]

Overview

Code cleanup on exportComponents

Before

Less readable

After

More readable

Technical Details

This encases the wrangling of the field format to it's own function.

This code is heavily tested

Comments

@colemanw

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

This seems like an ok intermediate step but ultimately I would hope that the processor expects $fields to be in the already wrangled format, and so it seems to me the wrangling belongs in a util class somewhere and marked @deprecated and, finally, will be removed with the ExportUi extension is merged into core.

[eileenmcnaughton]

@colemanw yeah - just trying to isolate the code that works with them

[colemanw]

@eileenmcnaughton tests make sad face

[eileenmcnaughton]

Hmm yeah - fixed - try again