Fix obscure bug on updating custom fields (not necessarily hittable via UI) #14754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…ia UI) This fixes a bug which I think only applies to programatically created custom fields -basically if the field has an empty option_group_id and then you update it to have one it does a check to see if the existing option_group_id is in use and does not handle the fact the field is empty - leading to a mysql error.
eileenmcnaughton
force-pushed
the
cust_field_fix
branch
from
808c81f to
aa4143b
Compare
|
test this please |
|
Merging based on code review & passing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a scenario where updating a custom field via the api fails - I think this can't be replicated in the uI
Before
If a custom group has no value in option_group_id and an api update adds one it fails (replicated in the test)
After
Succeeds
Technical Details
This fixes a bug which I think only applies to programatically created custom fields -basically if the field has an empty option_group_id
and then you update it to have one it does a check to see if the existing option_group_id is in use and does not handle the
fact the field is empty - leading to a mysql error.
Comments
The formatting commit is separately in #14753 - if that is merged first will rebase out