Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move function onto the processor class #14752

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code cleanup

Before

Code in static function

After

Code moved to export object

Technical Details

I went to extract the function that determines fields off to be a function on the processor class
but moving this first simplifies it

Comments

The function itself is pretty rubbish - I would use early returns - but was less fussed about that

@civibot
Copy link

civibot bot commented Jul 8, 2019

(Standard links)

@civibot civibot bot added the master label Jul 8, 2019
I went to extract the function that determines fields off to be a funciton on the processor class
but moving this first simplifies it
@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit b054c7a into civicrm:master Jul 8, 2019
@eileenmcnaughton eileenmcnaughton deleted the export branch July 8, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants