[REF] remove instances of pass-by-reference where no change takes place #14693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a grep on these and the passed params are not altered - down with php4
|
(Standard links)
|
|
test this please |
monishdeb
reviewed
Jul 2, 2019
| @@ -295,7 +294,7 @@ public static function buildForeignKeySQL($params, $separator, $prefix, $tableNa | |||
| * | |||
| * @return bool | |||
| */ | |||
| public static function alterFieldSQL(&$params, $indexExist = FALSE, $triggerRebuild = TRUE) { | |||
| public static function alterFieldSQL($params, $indexExist = FALSE, $triggerRebuild = TRUE) { | |||
|
|
|||
| // lets suppress the required flag, since that can cause sql issue | |||
| $params['required'] = FALSE; | |||
There was a problem hiding this comment.
@eileenmcnaughton do we need to carry forward this assignment?
There was a problem hiding this comment.
The function that calls it (the only one) doesn't make use of the $params afterwards
|
Its a straightforward change and makes sense. Merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Further removal of an obsolete code pattern (after grepping)
Before
$params passed by reference
After
$params not passed by reference
Technical Details
I did a grep on these and the passed params are not altered - down with php4
Comments
@colemanw