Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] extract prepareCreate from CustomField.create #14689

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Straight forward extraction - cleaning up code with a view to offering a more efficient wrapping function

Before

Code less readable

After

Code more readable

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 1, 2019

(Standard links)

@civibot civibot bot added the master label Jul 1, 2019
Straight forward extraction - cleaning up code with a view to offering a more efficient wrapping function
@eileenmcnaughton
Copy link
Contributor Author

@colemanw any chance you can check this - can trade review

@monishdeb
Copy link
Member

Tested working fine. Nice code extraction :)

@monishdeb monishdeb merged commit 526b880 into civicrm:master Jul 2, 2019
@eileenmcnaughton eileenmcnaughton deleted the cust_field_create branch July 2, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants