Use api to create activity and removed hardcoded status id

[pradpnayak]

Overview

Use api to create activity and removed hardcoded status id

Before

Status Id was hardcoded to 2

After

Replaced hardcoded value with name and used api to create activity

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

This seems straight forward, sensible, and inline with our general approach.

Do we have any tests that cover this createActivityExport function or more generally the CRM/Financial/BAO/ExportFormat class @pradpnayak

[pradpnayak]

I am afraid to say there isn't any unit test, I guess we had written webtest when it was implemented in 2014.

[eileenmcnaughton]

@pradpnayak any chance you could add 'something' with this change - I'd settle for 'anything that takes us forwards on test cover in this area - even if it just shows the function being called without a fatal

[eileenmcnaughton]

test this please

[pradpnayak]

@eileenmcnaughton yes i will, can you please help me if we have test related to export? I can come up with a unit test if i get a starting point.

[eileenmcnaughton]

@pradpnayak I would add something to CRM_Batch_BAO_BatchTest that calls

CRM_Batch_BAO_Batch::exportFinancialBatch($batchIds, $this->_exportFormat, $this->_downloadFile);

I feel like if you can just get to the point of calling the function with no errors that is enough to have extended our cover. - the CRM_Utils_System::civiExit(); function now throws an exception although per #14608 I'm still struggling to quite figure out how to do the testing using it (will have another dig on that one now)

[eileenmcnaughton]

test this please