Set title using standard form method and use for success message on contributionpage #14615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
force-pushed
the
contributionpage_title
branch
from
edd24b5 to
1ca02e8
Compare
mattwire
changed the title
|
@alifrumin This is the same change as #14614 but for contribution pages. Do you have time to take a quick look? |
|
Hey @mattwire I tested this on the jenkins build, specifically I created a new contribution page and checked that the title of the page shows up properly ("Configure Page - t1" in screenshot below). This looks ready to be merged to me.
|
|
Thankyou @alifrumin |
|
@eileenmcnaughton can you merge? |
|
This is a sensible code approach & @alifrumin has r-run it - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Switch to using standard form method for assigning title so we have access to the title during postprocess.
Before
Title not set on form object during postprocess.
After
Title set on form object during postprocess and used in the "Saved" message
Technical Details
Switch from CRM_Utils_System::setTitle() to $this->setTitle(). Assign the title to the form in CRM_Core_Form::setTitle() method as we've done with other extractions.
Comments