Convert Custom Data cache group to be using standard cache backend #14582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
convert_custom_data_cache_group
branch
2 times, most recently
from
603cd77 to
883d7dc
Compare
|
Jenkins re test this please |
seamuslee001
force-pushed
the
convert_custom_data_cache_group
branch
from
883d7dc to
cd5cd44
Compare
seamuslee001
force-pushed
the
convert_custom_data_cache_group
branch
2 times, most recently
from
8154c60 to
341914b
Compare
|
@eileenmcnaughton this should be fine for review now, it seems to only get set when editing cache data |
|
@seamuslee001 looks like the one I merged made this stale |
…setting withArray as fast for it Ensure custom data cache use the fastArray Cache
seamuslee001
force-pushed
the
convert_custom_data_cache_group
branch
from
341914b to
5d27ade
Compare
|
@eileenmcnaughton rebased now |
|
ok I think this is in keeping with other related PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a partial of #14487 which converts the custom data cache group to standard cache definition
Before
Uses deprecated caching functions
After
Uses standard caching functions and cache definition
Technical Details
If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary
Comments
When r-running this the reviewer should preform an advanced search and filter on a custom field, and confirm that when the advanced search pane re-loads that the custom field value that was set is retained