Fixed event type id fetch #14534
Merged
Fixed event type id fetch #14534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Any chance of a test.... |
|
Jenkins re test this please |
|
@pradpnayak Do we have an associated ticket or steps to replicate for this? |
|
jenkins retest this please |
|
@eileenmcnaughton i have pushed unit test for this. @yashodha I am not sure if its possible to replicate this from UI, but if you use CRM_Contact_BAO_Query() to find results with return property set to event_type_id then yes. |
|
@pradpnayak okay. Can you please squash all commits? |
Added unit test
pradpnayak
force-pushed
the
EventTypeQuery
branch
from
273b0d5 to
e4bee5e
Compare
|
@yashodha i have squased the commits. |
|
retest this please |
|
test this please |
|
OK this has a test now which is all it was stuck on - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using query search the event type id is returned as option_value.id instead option_value.value.
Before
When using query search the event type id is returned as option_value.id instead option_value.value.
After
When using query search the event type id is returned as option_value.value
Technical Details
Changed the select clause to get event type id from civicrm_event.event_type_id and also avoided join to option value when fetching only event type id.