dev/core#987 Reporthook

[sushantpaste]

Overview

Currently alterReportVars hook is invoked after grand total and section total calculations.
When alterReportVars used for altering any values in report rows , calculations does not take that into
consideration.
alterReportVars hook should invoked before grand total and section total calculations.

Before

When any rows data is changed in alterReportVars hook , those data changes is not reflecting into grand total or other calculations.

After

After applying patch data changes is not reflecting into grand total or other calculations.

Technical Details

In CRM/Report/Form.php hook is not invoke before calculations in formatDisplay().

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@sushantpaste Can you squash your commits?

[jaapjansma]

See the discussion in: https://lab.civicrm.org/dev/core/issues/987

[eileenmcnaughton]

I've come back to this & feel it needs an up or down decision. My general feeling is those report hooks are poorly designed & relying on them is a recipe for trouble - creating custom reports is a safer approach IMHO.

However, I agree that at the end of the day the grandTotal is more logically done on the 'final rows' and I feel like the risk is low- so I'm going to merge this despite my hesitations