WIP Upgrade Snappy and load it using composer instead of from civicrm_packages #14299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
alifrumin
changed the title
|
@alifrumin sorry looks like there's a merge-conflict |
|
Since the merge conflict is most of the change I'll close this & let you re-open it when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Snappy in civicrm-packages has not been updated in 4 years. This change upgrades snappy to v1.0.4 the last version of Snappy that is compatible which has a minimum php version of 7.0.
Before
Snappy out of date and loaded from civicrm-packages
After
Snappy v1.0.4 and loaded with composer
Comments
If this gets merged snappy could be removed from civicrm_packages