dev/core#891 condition on id existence when retrieving mailing hash #14113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
lcdservices
changed the title
|
@lcdservices This looks sensible, any chance you can put this against 5.13 branch as it would be good to get it into the RC tbh ping @eileenmcnaughton |
|
@seamuslee001 here's a second PR against 5.13 |
|
Closing this in favor of #14114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The presence of the mailing.viewUrl token with the mailing hash setting enabled expects the Mailing ID, which is not passed with the preview action (for performance reasons).
Before
With mailing hash enabled, the presence of the mailing.viewUrl token in a mailing would cause the mailing preview to hang and fail to open.
After
Preview opens as expected.
Technical Details
Same underlying issue as detailed in: #13956