referenece Organization Address and Contact Info, not FROM Email Addresses in help SMTP text (lab-879) #14055
Conversation
…esses in help SMTP text (lab-879)
|
(Standard links)
|
|
any idea why the conflicts cannot be resolved? seems weird to me. |
| @@ -102,7 +102,7 @@ public function postProcess() { | |||
|
|
|||
| if (!$domainEmailAddress || $domainEmailAddress == '[email protected]') { | |||
| $fixUrl = CRM_Utils_System::url("civicrm/admin/domain", 'action=update&reset=1'); | |||
| CRM_Core_Error::fatal(ts('The site administrator needs to enter a valid \'FROM Email Address\' in <a href="%1">Administer CiviCRM » Communications » FROM Email Addresses</a>. The email address used may need to be a valid mail account with your email service provider.', [1 => $fixUrl])); | |||
| CRM_Core_Error::fatal(ts('The site administrator needs to enter a valid email address in <a href="%1">Administer CiviCRM » Communications » Organization Address and Contact Info</a>. The email address used may need to be a valid mail account with your email service provider.', array(1 => $fixUrl))); | |||
There was a problem hiding this comment.
@michaelmcandrew This fatal should probably be replaced with CRM_Core_Error::statusBounce as it's pretty ugly triggering fatal when you get a setting wrong.
|
@michaelmcandrew could you please rebase out the merge-commit from this PR? |
|
test this please |
1 similar comment
|
test this please |
|
Replaced with #14329 |
|
@michaelmcandrew @eileenmcnaughton I believe it's the other way round: The text was correct, but linked to the wrong URL. Reason: The SMTP setup checks if a valid FROM address is set up before it allows to send a test email. If no valid FROM address is found, it triggers the message. The organizational contact email address has nothing to do with this and setting it does not help with sending the test email. The correct URL should (probably) be something like Honestly it's a problem with the configuration checklist as well as it does not make sense to configure the SMTP setup before the FROM address as the configuration checklists suggests. |
|
@fkohrt any chance you can do a PR to fix? |
|
@eileenmcnaughton done with #15165 :) But the order in the configuration checklist should be changed as well so that the From Address config precedes the SMTP setup. |
…tact Info instead of leading to From Email Addresses; see also civicrm#14055 and civicrm#14329
Overview
Fairly simple - the help text was wrong and did not match the URL, which is correct. See https://civicrm.stackexchange.com/questions/29261/how-to-setup-civicrm-to-proper-send-authenticated-dkim-emails/29264#29264 and https://lab.civicrm.org/dev/core/issues/879