Remove reference to non-iso date format from membership form tests #13965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
reviewed
Apr 5, 2019
| 'join_date' => date('m/d/Y', $unixNow), | ||
| 'start_date' => date('m/d/Y', $unixNow), | ||
| 'end_date' => date('m/d/Y', | ||
| 'join_date' => date('Y-m-d'), |
There was a problem hiding this comment.
@eileenmcnaughton why the extra space here?
There was a problem hiding this comment.
mostly to upset jenkins...
The date format wrangling is not handled by datepicker on the js layer so the php layer no longer needs to test for this
eileenmcnaughton
force-pushed
the
member_test
branch
from
39be922 to
8b40844
Compare
|
unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor cleanup in test to reflect our progress getting rid of jcalendar
Before
tests more confusing
After
test less confusing
Technical Details
The date format wrangling is not handled by datepicker on the js layer so the php
layer no longer needs to test for this
Comments