Allow extensions to enable validate.tpl #13961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
From eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor#106 I found that I couldn't enable our validation from the payment processor currently. It's a bit immature in that our front end presentation is poor,but this allows us to start improving that
eileenmcnaughton
force-pushed
the
validate
branch
from
a7dbddf to
d7d7dde
Compare
|
unrelated fail |
|
test this please |
|
This doesn't change the behavior in core so safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Makes it possible for extensions to cause validate to be added.
Validate.tpl provides front end javascript validation. This is a better user experience because the feedback to the user does not involve a slow form refresh. It was added & enabled in the past but caused some processor validation issues. I strongly suspect these would not recur as we handle required processor fields differently now but this provides a conservative way to make it available again.
Hopefully this is the predecessor to always enabling it.
Before
Cannot be enabled via an extension.
After
Can be enabled via an extesnion
Technical Details
From eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor#106
I found that I couldn't enable our validation from the payment processor currently.
It's a bit immature in that our front end presentation is poor,but this allows us to
start improving that
Comments