Move code to assign tax information into shared parent #13899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
reviewed
Apr 4, 2019
eileenmcnaughton
force-pushed
the
line_item
branch
from
2ee1539 to
617b52d
Compare
|
@eileenmcnaughton need some jenkins love https://test.civicrm.org/job/CiviCRM-Core-PR/25500/checkstyleResult/new/ |
|
@seamuslee001 did we change the standard? |
eileenmcnaughton
force-pushed
the
line_item
branch
2 times, most recently
from
47465c9 to
19c1100
Compare
|
test this please |
|
Reply to myself - we obviously HAVE changed the standard - I see it hit @agilewarealok as well today. Hopefully that won't be too painful |
mattwire
requested changes
Apr 4, 2019
eileenmcnaughton
force-pushed
the
line_item
branch
from
19c1100 to
e26cf9f
Compare
|
done |
mattwire
approved these changes
Apr 4, 2019
eileenmcnaughton
force-pushed
the
line_item
branch
from
e26cf9f to
f1b56c4
Compare
|
merging as tests passed (I did just rebase since another commit had snuck in but that's in master & not relevant to test success) |
This was referenced Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup around tax assignments
Before
Code not in a shareable place
After
Code more shareable - 3 other classes need to share this
Technical Details
@mattwire this is a bit of a chunkier cleanup so hopefully it's not too much. I was going to just clarify the tpl logic (ie let's specify whether to displayLineItems rather than intuiting if from a combination of parameters that are not directly related & then always assign line items) but then I went a bit further in cleaning up the form function. I wrote more comments :-)
Comments