dev/core#812 - Fix null display of contribution row on …

[jitendrapurohit]

…y page

Overview

RC fix for #13868. Null row is displayed on contact summary page if contact has 0 contribution.

Before

Screenshot from dmaster -

If any of the link is clicked on the row, it results into an error -

After

Fixed.

Technical Details

We removed the unnecessary financial type join from the contribution table in #13720

Before the above fix, the query included the financial type which unintentionally avoided the null row to be returned as output -

SELECT  civicrm_contribution.id, .......... 
FROM civicrm_contact contact_a 
    LEFT JOIN civicrm_contribution ON civicrm_contribution.contact_id = contact_a.id  
    INNER JOIN civicrm_financial_type ON civicrm_contribution.financial_type_id = civicrm_financial_type.id  
    LEFT  JOIN civicrm_contribution_product ON civicrm_contribution_product.contribution_id = civicrm_contribution.id 
    LEFT  JOIN civicrm_product ON civicrm_contribution_product.product_id =civicrm_product.id 
WHERE  ( contact_a.id = '202' )  AND (contact_a.is_deleted = 0)   
  GROUP BY civicrm_contribution.id  ORDER BY `receive_date` desc, `contact_a`.`id`  LIMIT 0, 50 

After the removal of financial type join, the query is -

SELECT  civicrm_contribution.id, ......
FROM civicrm_contact contact_a 
    LEFT JOIN civicrm_contribution   ON civicrm_contribution.contact_id = contact_a.id
WHERE  ( contact_a.id = '202' )  AND (contact_a.is_deleted = 0)   
GROUP BY civicrm_contribution.id  ORDER BY `receive_date` desc, `contact_a`.`id`  
LIMIT 0, 50 

As it is a left join and no other field, the contact null row gets returned and is displayed on the contribution tab. @eileenmcnaughton

Comments

Gitlab - https://lab.civicrm.org/dev/core/issues/812

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Cool this will clear out the regression column! (& we are back under 100 prs - although I'm sure a lot are not review-ready)