dev/core#766 fix loss of custom fields when creating an event from template #13755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton this solves the problem for me! Thank you! |
|
Merging as per the review from Ken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes 5.9 regression whereby creating an event from template does not save custom field data
Before
Custom data entered in the event not retained when creating event from template
After
Data saved
Technical Details
A while back the code was updated to use the copyGeneric function, handling of custom data was not addressed then
Comments
https://lab.civicrm.org/dev/core/issues/766#note_14381
@mattwire @seamuslee001 I think we should get this in 5.11