dev/core#770 - View Case Activity page displays disabled custom fields #13741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Mar 1, 2019
CRM/Case/XMLProcessor/Report.php
Outdated
| @@ -581,10 +581,11 @@ public function getCustomData($clientID, $activityDAO, &$activityTypeInfo) { | |||
| /** | |||
| * @param int $activityTypeID | |||
| * @param null $dateFormat | |||
| * @param boolean $onlyActive | |||
There was a problem hiding this comment.
@jitendrapurohit please change this to bool and tests will pass, thanks.
|
Jenkins re test this please |
|
@jitendrapurohit style warning |
jitendrapurohit
force-pushed
the
core-770
branch
from
721a39a to
54f5453
Compare
|
test this please |
|
unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
View Case Activity page displays disabled custom fields
Before
Replicate it by -
Viewlink in the activity row and notice the disabled field shown on the page.After
Fixed.
Comments
Gitlab - https://lab.civicrm.org/dev/core/issues/770