dev/membership#10 fix incorrect validation error saying Start date must be the same or later than Member since #13734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st be the same or later than Member since This problem is because both dates exclude time but the default setting includes it - leading to a comparison of a datetime with a date+midnight time
|
(Standard links)
|
|
is there a test that covers this? @eileenmcnaughton |
|
@seamuslee001 I doubt it - it's very formy. |
|
I think it won't be an issue because the join date is not a timestamp field but a date field. Neither we are showing the time part in UI or saving it in DB. Plus we are setting it on default not something on submission or interanl BAO fns. So I am approving this PR |
monishdeb
approved these changes
Mar 1, 2019
|
Merging based on @monishdeb approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
"Start date must be the same or later than Member since" triggered when dates are the same
Before
-> new membership
-> set start_date to match join_date (don't change join_date field - problem is with default 'now'
-> validation error on save
After
no error
Technical Details
This problem is because both dates exclude time but the default setting includes it - leading to a
comparison of a datetime with a date+midnight time
Comments
https://lab.civicrm.org/dev/membership/issues/10