Status of test contribution is not fetched on ThankYou page.

[agilewarealok]

Overview : Steps to reproduce the bug

1. Create a Contribution Page (Without confirm page) with Payment processor which captures the Payment instantly.
2. Open the contribution page Test-Drive URL without logging into the CiviCRM
3. Fill in the Billing and amount details
4. Click on Submit
5. Payment processor captures the payment instantly and user redirected on ThankYou Page.
6. Confirmation message on ThankYou page is
   Your contribution has been submitted to XYZ

Even though the payment is already captured the confirmation message is misleading.

Before

Status of Test contribution is not fetched resulting in misleading confirmation message.

After

Correct status of test contribution is fetched so confirmation message is appropriate.

Comments

Agileware Ref: CIVIEWAY-42

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[agilewarealok]

@eileenmcnaughton
Can you please review this ? PR we were discussing on MM.

[eileenmcnaughton]

As discussed test doesn't exactly catch the bug but it does improve test cover & pave the way for next time. Bug fix = safe & sensible