Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

financial#46 - clean money format at form layer #13721

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

MegaphoneJon
Copy link
Contributor

Overview

When specifying a donation amount of $1000 or more (on a monolingual en_US site), the amount is saved as $1,000.00.
When you press save again, the comma is treated as a decimal separator, and so it's resaved as $1.

Before

19 second screencast showing the issue:
https://lab.civicrm.org/dev/financial/uploads/3efa6a65f2585256b3792f512ce29416/thousandseparatorbug-2019-02-27_16.07.04.mkv

After

Amount saves correctly.

Technical Details

The "Amounts" tab of contribution page configuration doesn't clean the money format at the form level. Since cleaning at the BAO level was removed in 5.9.0, we need to clean the money at the form level.

@civibot
Copy link

civibot bot commented Feb 28, 2019

(Standard links)

@civibot civibot bot added the master label Feb 28, 2019
@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.11 February 28, 2019 05:27
@civibot civibot bot added 5.11 and removed master labels Feb 28, 2019
@eileenmcnaughton
Copy link
Contributor

I tested this & it worked fine - it looks correct to me - merge on pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants