financial#46 - clean money format at form layer #13721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When specifying a donation amount of $1000 or more (on a monolingual en_US site), the amount is saved as $1,000.00.
When you press save again, the comma is treated as a decimal separator, and so it's resaved as $1.
Before
19 second screencast showing the issue:
https://lab.civicrm.org/dev/financial/uploads/3efa6a65f2585256b3792f512ce29416/thousandseparatorbug-2019-02-27_16.07.04.mkv
After
Amount saves correctly.
Technical Details
The "Amounts" tab of contribution page configuration doesn't clean the money format at the form level. Since cleaning at the BAO level was removed in 5.9.0, we need to clean the money at the form level.