Upgrade PHPWord

[seamuslee001]

No description provided.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

The general pattern for doing this safely as well-behaved member of a complex system is:

$backupValueThatIDontMakeAnyAssumptionsAbout = readTheGlobalValue():
setTheGlobalValue($theValueThatILike);
try {
   doTheMainThing();
}
finally {
  setTheGlobalValue($backupValueThatIDontMakeAnyAssumptionsAbout);
}

On a case-by-cases basis, there might be a prettier way (e.g. maybe depending on the contract of the specific global-thing or maybe using CRM_Utils_AutoClean::swap() or maybe using CRM_Utils_GlobalStack).

[seamuslee001]

@totten got it to pass :-)

[eileenmcnaughton]

@seamuslee001 are there remaining reasons not to merge now?

[seamuslee001]

nothing on my side but would appreciate Tim's opinion as well

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

We should actually go to the latest version I think
https://github.com/PHPOffice/PHPWord/releases

My experience with phpword is that we have had more than one case where the fix to some reported issue is to upgrade - as long as it's compatible with our min php version I think keeping it current solves more problems than it's likely to risk causing

[colemanw]

Looks like the latest is v0.16.

@seamuslee001 will that newer version still require your entity_loader patch?

[seamuslee001]

@colemanw yes it would still need those patches

[eileenmcnaughton]

So I'm happy to merge this as a 'technical' fix to the problem of 'how do we upgrade phpword - although getting the latest bug fixes would be better