[REF] minor code cleanup - do not build order var just to hurt brains

[eileenmcnaughton]

Overview

minor code cleanup

The order var is basically orderBy prepended by Order by - which is then stripped.

Just don't

Before

More brain pain

After

less brain pain

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton test failure here https://test.civicrm.org/job/CiviCRM-Core-PR/24584/testReport/junit/(root)/CRM_Contact_SelectorTest__testSelectorQuery/testSelectorQuery_with_data_set__4/ is relevant

[eileenmcnaughton]

@seamuslee001 yeah - an enotice - I can fix that by declaring it but are you ok to give it merge on pass?

[eileenmcnaughton]

@seamuslee001 look how cheerful jenkins is now - I'm gonna clean up this function as it has some bugs & it is sh*te to read atm

[seamuslee001]

Looks fine to me Jenkins has passed it merging