[REF] minor refactor around retrieving processor id for recur

[eileenmcnaughton]

Overview

Minor extraction

Before

uses sql

After

uses api

Technical Details

This is primarily so that we can start calling the latter function in places where the id is only retrieved in order to check it exists -

• next steps are to deprecate & remove calls like

CRM_Financial_BAO_PaymentProcessor::getProcessorForEntity($recurID, 'recur', 'obj')

and

getPaymentProcessorForRecurringContribution (which duplicates this although I think it uses a better method to load the object.)

Note that I think we should load the manual payment processor if the value is actually empty - that makes it editable which I think makes sense where they have been added other than via normal civi mechanisms - this could include imports or just odd requirements

Comments

@mattwire

preliminary towards https://lab.civicrm.org/dev/core/issues/704

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

CRM_Contact_Page_View_UserDashBoardTest::testDashboardContentContributionsWithInvoicingEnabled
Undefined index: payment_processor_id

relates - will check

[eileenmcnaughton]

I hit an enotice in the tests & when I looked here I found that we have just done a dao->fetch so we already have the payment_processor_id - looks to me like the check is for something obsolete anyway - see orphan paymentObject later on... - probably this was to get the url but that's not in the function now

[mattwire]

• @throws \CiviCRM_API3_Exception

[mattwire]

Incremental cleanup for payment processor stuff which is good.

@eileenmcnaughton I can't actually find where CRM_Contribute_BAO_ContributionRecur::getPaymentProcessor() is being called?

[eileenmcnaughton]

@mattwire looks like I removed the one place in this PR :-) But I think this is my preferred of the 3 variants of the function so we should migrate to this one

[mattwire]

I've tested this locally and it works. It's a preliminary refactor with no visible change. ok to merge