Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] extract basic soft credit stats to separate function #13622

Merged
merged 1 commit into from
Feb 17, 2019
Merged

[REF] extract basic soft credit stats to separate function #13622

merged 1 commit into from
Feb 17, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 17, 2019 •
edited
Loading

Overview

Code clean up preliminary to resolving performance issues

Before

Code hard to read

After

Code more readable

output ugly but unchanged
screenshot 2019-02-17 17 37 30

Technical Details

Partial of #13607 - adding 'has-tests' which were merged in #13605

Comments

@civibot civibot bot added the master label Feb 17, 2019
@civibot
Copy link

civibot bot commented Feb 17, 2019

(Standard links)

@eileenmcnaughton eileenmcnaughton mentioned this pull request Feb 17, 2019
Merged
@colemanw colemanw merged commit c6bcda8 into civicrm:master Feb 17, 2019
@eileenmcnaughton eileenmcnaughton deleted the cont_summary_extract1 branch February 17, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw