[REF] extract add median to stats #13616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Feb 17, 2019
CRM/Contact/BAO/Query.php
Outdated
| * @param string $from | ||
| */ | ||
| protected function addMedianToStats(&$summary, $where, $from) { | ||
| $medianSQL = "{$from} {$where} ND civicrm_contribution.contribution_status_id = 1 "; |
There was a problem hiding this comment.
ND?
Copy-paste error?
I'm interested to see if the tests catch it. If so then adding merge-on-pass is a no-brainer.
There was a problem hiding this comment.
opps - I re-tweaked that commit when pulling it out from the borg.... yeah tests will fail
|
@colemanw voila - proof |
|
Cool |
eileenmcnaughton
force-pushed
the
cont_summary_extract1
branch
from
82187c9 to
2ec9f0f
Compare
|
ok fixed now.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code clean up preliminary to resolving performance issues
Before
Code hard to read
After
Code more readable
output ugly but unchanged
Technical Details
Partial of #13607 - adding 'has-tests' which were merged in #13605
Comments