Payment.sendconfirmation api - add further tpl variables. #13610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton now when #13609 is merged, can you please rebase this PR? |
eileenmcnaughton
force-pushed
the
payment_conf2
branch
from
1adc7c3 to
565920d
Compare
|
@monishdeb done |
This was referenced Feb 20, 2019
monishdeb
reviewed
Feb 20, 2019
| 'isRefund' => $entities['payment']['total_amount'] < 0, | ||
| 'isAmountzero' => $entities['payment']['total_amount'] === 0, | ||
| 'refundAmount' => ($entities['payment']['total_amount'] < 0 ? $entities['payment']['total_amount'] : NULL), | ||
| 'paymentsComplete' => ($entities['payment']['balance'] == 0), |
monishdeb
reviewed
Feb 20, 2019
| 'billingName', | ||
| 'address', | ||
| 'credit_card_type', | ||
| 'credit_card_number', | ||
| 'credit_card_exp_date', | ||
| 'eventEmail', | ||
| '$event.participant_role', |
There was a problem hiding this comment.
@eileenmcnaughton should we remove these two event parameters (as an indicator)? I didn't found any occurrence in form where its been assigned
There was a problem hiding this comment.
@monishdeb so that was my list of things to add to meet the tpl's requirements but when I reviewed the tpl I decided they were derived parameters (with the tpl) not assigned parameters
|
Tested the patch, working fine. Also the added UT successfully asserts the presence of new template variables. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Payment.sendconfirmation is an api added in 5.12 - this is part of that. The api will replace the form email confirmation logic once mature
Before
Less complete
After
More complete
Technical Details
Incorporates & extends #13609
Comments
There are a couple of parameters assigned to the template i the form - but they are not used
@jitendrapurohit I think once this is merged we could replace emailReceipt with an api call to Payment.sendconfirmation. There is nothing else in that fn that is done AND used in the tpl from what I can see