Test-drive contribution pages to the front

[jgillmanjr]

Overview

Specify that Test-drive contribution pages are front end. Addresses this issue.

Before

Test-drive contribution pages would be displayed in the backend of Wordpress. This also lead to the IPN notification URLs to be set to the backend (which obviously won't work).

After

Test-drive contribution pages now point to the front end. IPN notification URLs also point back to the front end.

Technical Details

First change involves CRM/Contribute/Page/ContributionPage.php and assigns 'fe' => TRUE for the preview action.

Second change involves CRM/Core/Payment.php and specifying $frontend to be TRUE in the call to CRM_Utils_System::url().

Comments

The second change doesn't appear to be required given the first change seemed to address the issue as outlined over in Lab and on StackExchange. However, I figure it might serve as a potential backstop.

I'm more than happy to pull that one if it shouldn't be there.

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jgillmanjr]

Also, significant thanks to @christianwach - I wouldn't have even thought/known about the first change without him.

[seamuslee001]

Jenkins add to whitelist

[jgillmanjr]

Huh. Test failure for something which I didn't touch.

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

test fail is something unrelated

Test Result (2 failures / ±0)CRM_Utils_GeocodeTest.testGeocodeMethodOffCRM_Utils_GeocodeTest.testStateProvinceFormat

[colemanw]

I'm going to merge this based on review and testing by @christianwach. The code looks good to me as well.

[christianwach]

Thanks @colemanw 👍