Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy-up] remove a couple of useless bits of code #13447

Merged
merged 2 commits into from
Jan 14, 2019
Merged

[tidy-up] remove a couple of useless bits of code #13447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
340c24c
Remove unused parameter
eileenmcnaughton Jan 14, 2019
88bd6eb
Remove verify_mandatory that does nothing due to nothing to verify
eileenmcnaughton Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion api/v3/File.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ function civicrm_api3_file_create($params) {
* Array of all found file object property values.
*/
function civicrm_api3_file_get($params) {
civicrm_api3_verify_one_mandatory($params);
return _civicrm_api3_basic_get(_civicrm_api3_get_BAO(__FUNCTION__), $params);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/CiviTest/CiviUnitTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2727,7 +2727,7 @@ public function setupACL($isProfile = FALSE) {
if (!$isProfile) {
//flush cache
CRM_ACL_BAO_Cache::resetCache();
CRM_ACL_API::groupPermission('whatever', 9999, NULL, 'civicrm_saved_search', NULL, NULL, TRUE);
CRM_ACL_API::groupPermission('whatever', 9999, NULL, 'civicrm_saved_search', NULL, NULL);
}
}

Expand Down