Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Add to group on create new report after refresh of result #13404

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

pradpnayak
Copy link
Contributor

@pradpnayak pradpnayak commented Jan 4, 2019

Overview

https://lab.civicrm.org/dev/core/issues/642

Before

JS error when trying to create report

After

Actions and Add to group options are not displayed until 'View result' button is clicked at the time of creating new report

@civibot
Copy link

civibot bot commented Jan 4, 2019

(Standard links)

@civibot civibot bot added the master label Jan 4, 2019
@pradpnayak
Copy link
Contributor Author

jenkins restest this please

@eileenmcnaughton
Copy link
Contributor

@pradpnayak I completely agree on add to group but do we also need to remove the actions - the use case I know of is a slowish report where they want to export to csv (or create / delete a report) without having to run view results first because it gives a slow UI experience

@seamuslee001
Copy link
Contributor

seamuslee001 commented Jan 6, 2019

@eileenmcnaughton isn’t this only limited to where your creating a new report from template not when you already have a report instance?

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 right - so the delete report is not correct above - but creating or exporting without first running is

@eileenmcnaughton
Copy link
Contributor

@pradpnayak I'm still only convinced here about removing add2group - see my comment above

@pradpnayak
Copy link
Contributor Author

@eileenmcnaughton I have updated PR to remove add2group. Will submit separate PR to fix JS error on New report.

@pradpnayak pradpnayak changed the title Show Actions on create new report after refresh of result Show Add to group on create new report after refresh of result Feb 4, 2019
@eileenmcnaughton
Copy link
Contributor

OK looks fine now

@eileenmcnaughton eileenmcnaughton merged commit 90b7caa into civicrm:master Feb 11, 2019
@pradpnayak pradpnayak deleted the ReportActions branch March 23, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants