fixes core#609 - view 'Advanced Search' links without 'view all conta… #13390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Agree with this change. @eileenmcnaughton @seamuslee001 what do you think? |
|
Yeah I think I'm + 1 - adding 'merge ready' to give a little longer for input (@lcdservices @davejenx in case you have some) |
eileenmcnaughton
added
the
merge ready
|
I have no issue with that change. |
|
Seems OK to me. |
|
Ok, we got four approval (including mine) for merge. Merging now. Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cts' permission
Overview
You currently need "View All Contacts" permission to see the "Advanced Search" link on a mailing report, but not the "Report" link. This is inconsistent, and I can't think of a use case where the inconsistency is desirable.
Before
The "Advanced Search" links (see screenshot) are missing unless you have "View All Contacts" permission.
After
Advanced Search links are present.
Technical Details
We're simply removing the permission check.
Comments
I considered the argument that this search gives you incomplete results because you can't see all contacts. However, this is true for ANY search as a user who can't see all contacts, and is also applicable to the "Report" link, which is not permissioned.