REF Convert deprecated functions to buildOptions for case #13364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwire
force-pushed
the
activitytype_pseudoconstant
branch
2 times, most recently
from
9da60b3 to
889e61f
Compare
|
Jenkins re test this please |
mattwire
force-pushed
the
activitytype_pseudoconstant
branch
from
889e61f to
0f103b7
Compare
|
@colemanw @seamuslee001 Either of you able to give this a quick review? |
| @@ -112,8 +112,8 @@ public static function actionLinks( | |||
| $activityId = NULL, | |||
| $key = NULL, | |||
| $compContext = NULL) { | |||
| static $activityActTypes = NULL; | |||
There was a problem hiding this comment.
Changes to this file checked & oK
| @@ -1058,7 +1058,6 @@ public static function getCaseActivity($caseID, &$params, $contactID, $context = | |||
| $caseCount = CRM_Core_DAO::singleValueQuery('SELECT FOUND_ROWS()'); | |||
eileenmcnaughton
added
the
merge ready
|
@mattwire I think there are a few places where this could be a little improved but none are blocking so if you don't wish to revisit them I'm OK to merge - although I don't think they will get later if you don't |
mattwire
force-pushed
the
activitytype_pseudoconstant
branch
from
0f103b7 to
003de00
Compare
mattwire
force-pushed
the
activitytype_pseudoconstant
branch
from
003de00 to
b864360
Compare
|
@eileenmcnaughton I've addressed your comments - can we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Convert
CRM_Core_PseudoConstant::activityType()andCRM_Core_PseudoConstant::activityStatus()to non deprecatedbuildOptions()function.Fix a couple of PHP notices.
Before
Deprecated code, php notices.
After
Less deprecated code, less PHP notices
Technical Details
In most cases these methods are functionally the same. In some cases the
buildOptions()replacement foractivityType()function also returns campaign activities but this does not matter because the activity type arrays are being used to lookup (via array_search) specific activity types.Comments