Remove activitystatus js. Add submitOnce handler for activity create

[mattwire]

Overview

Related to #13333 which has now been merged.

On some sites activities can be duplicated by clicking submit/save multiple times when adding an activity. It does not seem easy to reproduce on other sites (eg. dmaster demo). However, looking at the code and simulating multiple clicks in the browser it is certainly possible to submit and there is no protection against creating multiple activities. So I suspect that slower servers/slower browsers are more likely to create duplicates.

This PR also removes javascript which is meant to warn the user if a scheduled activity is in the past or a completed one in the future. However, this js doesn't work on either dmaster.demo or any of my test/live sites and has not been modified for 5 years. As this code also adds an onclick handler it makes it much more difficult to add the "submitOnce" handler. As it seems like this code has not worked for a long time I think it is sensible to just remove it and simplify the form - a site could implement similar functionality via jquery in an extension if desired?

Before

Possible to create multiple activities by clicking "save" multiple times.

After

Only possible to click "save" once so activity create is only submitted once.

Technical Details

Relies on #13333 which adds an onclick handler to the submit buttons.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[jitendrapurohit]

I was able to create more than 1 activities by hitting multiple times on a save button before the form is actually submitted. So this actually replicated on my local setup hence thought of giving it a review :-).

Tested by applying this + #13333 changes on my local - I get a series of warning after submitting the activity form.

[mattwire]

@jitendrapurohit Thanks for review - I can't reproduce this (no php warnings)... did you have some other customisation, clearcache? or can you provide steps to reproduce?

[jitendrapurohit]

To replicate -

• Create an activity from civicrm/activity?reset=1&action=add&context=standalone. The form should be opened on a window and not on the ajax dialog box.
• Click save - the page redirects to the civicrm dashboard.
• Open any link from the recent items, eg the view activity link which was created from the above point.
• This should list the notices on the page. It works fine without this PR applied.

Hope that helps.

[mattwire]

@jitendrapurohit Thankyou, that should be fixed now. Can you try again?

[seamuslee001]

Jenkins re test this please

[mattwire]

@colemanw Thanks for merging #13333 Are you happy to merge this one too? As it follows on from that one.

[colemanw]

In my testing, I was able to create 15 activities at once before applying this patch (I'm a fast clicker).
After the patch, only one :)
Good to merge, thanks Matt.