Fix order api to support a pseudoConstant for financial_type_id #13317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
order_pseudo
branch
from
233a0f9 to
3e54330
Compare
|
Jenkins re test this please |
|
Test failure looks related @eileenmcnaughton |
|
Jenkins re test this please |
|
Code looks good and also tested using api explorer, Financial type is populated with values on create mode.
However the test failures looks related. |
eileenmcnaughton
force-pushed
the
order_pseudo
branch
from
3e54330 to
7e5f786
Compare
|
Ok - I think I've fixed the api test - the change meant it had to support 'order_id' as 'id' to pass Syntaxconformance - now fixed - merge on pass @seamuslee001 ? |
Adds functionality & test to support 'Event Fee' instead of '4' for Order.create financial_type_id. This improves consistency with Contribution.create api and others
eileenmcnaughton
force-pushed
the
order_pseudo
branch
from
7e5f786 to
785f03e
Compare
|
unrelated fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds functionality & test to support 'Event Fee' instead of '4' for Order.create financial_type_id.
This improves consistency with Contribution.create api and others
Before
civicrm_api3('Order', 'create', [
'financial_type_id' => 'Event fee',
'total_amount' => 300,
'....
]);
Fails as financial_type_id cannot be validated
After
Above call works
Technical Details
Order.create api is an alias for Contribution.create api at the top level and it makes sense it supports the same pseudoconstants. Arguably it should start with the getfields output from Contribution.create but I've kept scope small & tested
Comments
@monishdeb @pradpnayak