(REF) Allow subclasses of AbstractTokenSubscriber to override the determination of active tokens. #13186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| public function getActiveTokens(TokenValueEvent $e) { | ||
| $messageTokens = $e->getTokenProcessor()->getMessageTokens(); | ||
| if (!isset($messageTokens[$this->entity])) { | ||
| return NULL; |
There was a problem hiding this comment.
@aydun just thinking should this return FALSE as it feels a bit more clearer
There was a problem hiding this comment.
@seamuslee001 Ok, I've changed that to FALSE if you think that's clearer. I was following the pattern of the pre-existing prefetch() just below it, but either works.
This enables variable named tokens.
aydun
force-pushed
the
override_active_tokens
branch
from
cd70609 to
eb96909
Compare
|
Test failures don't seem to be related to this change - external service unavailable? |
aydun
changed the title
|
test this please |
1 similar comment
|
test this please |
|
@eileenmcnaughton Ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is extracted from PRs #13174 and #12012 By refactoring the determination of active tokens into a separate function
getActiveTokens(), subclasses ofCivi\Token\AbstractTokenSubscribercan override this definition if desired.No functional change.