dev/core#527 Add in abiity to set translated text for Submit and Canc…

[seamuslee001]

…el button text

Overview

This adds in the ability for Users to set different text per language for these fields when editing the settings

Before

Could not enter different text per language

After

Can enter text per language

ping @eileenmcnaughton @samuelsov

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Hmm - we are really moving toward using shared code for this sort of stuff - ie. per the entity settings form & the related Tpl

[seamuslee001]

@eileenmcnaughton sure understand that but given this is an additional file that is bundled in (its an accordion on the profile setting page) i'm not sure how it would work on the entity setting form.

[eileenmcnaughton]

@seamuslee001 so you can replace a part of a tpl with the standard field/s template like this - it permits some fields to be transitioned across without having to do the whole form. The key part is that all the metadata is in $fieldSpec before the {include file="CRM/Core/Form/Field.tpl"} is called

      {foreach from=$tpl_standardised_fields item=fieldName}
       {assign var=fieldSpec value=$entityFields.$fieldName}
       <tr class="crm-{$entityInClassFormat}-form-block-{$fieldName}">
          {include file="CRM/Core/Form/Field.tpl"}
        </tr>
      {/foreach}

[eileenmcnaughton]

Obviously you need to assign metadata to the tpl in some array - but that's kinda the point - the more we mature our metadata the better prepared we are to NOT be on QF anymore

[seamuslee001]

@eileenmcnaughton ok i think i have it now it was a little tricky to ensure the fields didn't get displayed in the main part of the form

[seamuslee001]

@eileenmcnaughton note the class here is because of some javascript that hides all cancel button sections if the show cancel button field is not checked

[seamuslee001]

This ensures that the new fields don't show on the main part of the form as well as on the advanced settings section

[eileenmcnaughton]

not hugely important but I think !in_array would be more consistent with elsewhere than 'not'

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

I just tested this & it works well. Code looks good. Merge on pass

[seamuslee001]

thanks @eileenmcnaughton

[seamuslee001]

Merging as per the tag