Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup query logic - followup on GH-12991 #13055

Merged
merged 1 commit into from
Nov 2, 2018
Merged

cleanup query logic - followup on GH-12991 #13055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions CRM/Contact/BAO/Query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2305,12 +2305,7 @@ public function restWhere(&$values) {
$fieldName = "contact_a.{$fieldName}";
}
else {
if ($op != 'IN' && !is_numeric($value) && !is_array($value)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eileenmcnaughton um what? :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seamuslee001 I think the LOWER came out of one of those rows - agree this cleanup is needed now! Good to merge

$fieldName = "{$field['where']}";
}
else {
$fieldName = "{$field['where']}";
}
$fieldName = $field['where'];
}
}

Expand Down