Remove lowercasing in relationship query

[eileenmcnaughton]

Overview

Removes another instance of non-functional lower casing in searches - which cause some strings to be hishandled

Before

Relationship search passes strings through lower casing. This is not compared with a lower case string so mysql handles the comparison, but can fail on some charactersets. I acheives nothing & causes edge-case harm

After

strtolower removed

Technical Details

This was picked up as being tested through testCreateSavedSearchWithSmartGroup as part of #12494 - the test actually already uses a non-lower case string 'Default Organization' - I found the casting to an array broke my ability to step through the code line by line so I tidied that slightly.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

@seamuslee001 passed now

[eileenmcnaughton]

@seamuslee001 my feeling is we are better to merge the rest of these tweaks into one release now - it feels less risky than spreading out the 'odds & sods' ones - although I'm not that worried now.

[seamuslee001]

This function is well backed up by unit tests following recent work. I am confident enough that if there was an issue Jenkins will have found it. Merging