Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate upgrade step for 5.7.beta1 in 5.8.alpha1 to capture anyone … #13033

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

seamuslee001
Copy link
Contributor

@civibot
Copy link

civibot bot commented Oct 29, 2018

(Standard links)

@civibot civibot bot added the master label Oct 29, 2018
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 isn't 5.7 the rc? In which case the upgrade script was merged to 5.7 in time for release?

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton yes but what if someone has already downloaded the 5.7 RC tarball sometime in the last month and upgraded? their db version will be 5.7.beta1 with the old icons

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 OK - I would say we don't really cater to that but OTOH I can't see this does any harm!

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@seamuslee001
Copy link
Contributor Author

Merging as per the tag

@seamuslee001 seamuslee001 merged commit c2e6acc into civicrm:master Oct 30, 2018
@seamuslee001 seamuslee001 deleted the icon_style_guide_5_8 branch October 30, 2018 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants