Activities can be linked to multiple cases. Handle caseIds being an array

[mattwire]

Overview

This was found when submitting a drupal webform with a case and an activity and some custom code on a post hook which does an activity.get API call and then an activity.create to update the activity.

Here is an example of an API call that will give you an array for case_id:

$result = civicrm_api3('Activity', 'get', [
  'sequential' => 1,
  'return' => ["case_id"],
  'case_id' => ['IS NOT NULL' => 1],
]);

The \Civi\CCase\fireCaseChange function doesn't handle the case when $caseIdsis an array, yet the callback function it calls does handle$caseIds` being an array. The result is that PHP throws some warnings about illegal offset type and the caseId is never added to the static cache and thus gets fired multiple times.

Before

CaseIds as array not handled properly, PHP warnings and case changed event fired multiple times (as not cached).

After

CaseIds as array handled properly. Cached properly and only fired once.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Totally agree with this change. Happy to merge since test pass.