dev/translation#15 Fix backend CC contributions left pending if statuses are localised

[mlutfy]

Overview

To reproduce:

• Modify the Contribution Statuses, so that the label for Complete is 'Terminé' (https://dmaster.demo.civicrm.org/civicrm/admin/options?gid=11&reset=1) - this changes the label, not the name, so that we can localize the contribution statuses.
• Go to a contact record and record a new credit card contribution (you can use the dummy processor)

Details & animated GIF: https://lab.civicrm.org/dev/translation/issues/15

Before

The contribution is left as pending.

After

The contribution is completed.

Technical Details

The usual "option values had obscure function names and programmers did lots of errors".

Comments

The fix was suggested by @mattwire

Symbiotic has been running this patch for the past month.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[JoeMurray]

The code looks good to me. As it has been running in production for a month, I'd say Merge on Pass.

[mattwire]

Agreed. @eileenmcnaughton I'm happy with this if you'd like to merge