Remove contact tags when none selected on edit screen #12981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Contact are not untagged when all the values from tag select drop down is unselected.
merged to 5.7 in #12958
Steps to reproduce:
Log in to CRM
Go to Individual's profile
Click the button "Edit"
Open block "Tags and Groups"
Delete data from field "Tag(s)"
Click the button "Save"
Result: The information in the tag field is not updated (see below gif file)
Expected result: The field "Tag(s)" has been updated.
Before
After
Technical Details
When Tags are unselected on Contact edit form $params['tags'] is empty and hence it doesn't call create entity tag function where it removes or adds tags depending upon $params['tags'] array passed. The create entity tag function first gets all the tags of the contact and then diff with $params['tags'] and untags the contact from result of diff.