[NFC] code cleanup in api_v3_CaseTest

[eileenmcnaughton]

Overview

non functional tidy up in test class

Before

no change

After

no change

Technical Details

removes unused variables, fix comments, fix deprecated practices -ie

• $dao->free() - this is now done by $dao->_destruct and in rare scenarios breaks data integrity if it is called.
• declaring the test breakage line - ie. '' in line ' . LINE' - this is now redundant
• calling civicrm_api in tests - we call $this->callAPISuccess

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).